Thread: HTML DOJO
View Single Post
Old Nov 28th, 2012, 3:14:10 AM   #30
ium
is an official Team Rateris a Community Contributoris a Contributor to Smogon Mediais an Artist Alumnus
 
ium's Avatar
 
Join Date: Sep 2012
Posts: 459
Default

Quote:
Originally Posted by Fat Mikel View Post
...


Oh my goodness that was far too long. Anyway it's been four years since I did CSS and stuff last so I'm pretty rusty and probably got stuff wrong.

EDIT: hurr, looked at the scms afterwards because lol curiosity, and damn it i was right using <p><strong> instead of <h4 class="rmt">. oh well lesson learned.
instead of <h2 class="head"></h2>, you could have just done <div style="text-align:center;"><h2></h2></div> just to simplify the css even more since you're not using that class anywhere else except for that one instance.

and i am pretty sure that the <strong> and <p> tags are not necessary because the header tags already handle that for you. just some simple <h2> or whatever <h#> tags would have been good.

also, -webkit-border-radius:6px;-moz-border-radius:6px; is not sufficient. you need to put border-radius:6px; as well.
if you were curious, the actual border radius used in the smog's css is 12px and has some margining.

uh, you also missed a self-closed tag <img src="" alt="" /> on line 223.

i am not sure what <div class="tl"></div><div class="tr"></div> does either. that can go.
edit: <div class="bl"></div><div class="br"></div> is useless too.
__________________
ium is offline   Reply With Quote