1. New to the forums? Check out our Mentorship Program!
    Our mentors will answer your questions and help you become a part of the community!
  2. Welcome to Smogon Forums! Please take a minute to read the rules.

Gen 1 Critical Hits may have been intended to happen four times less often (theory)

Discussion in 'Ruins of Alph' started by Crystal_, Dec 30, 2013.

  1. Crystal_

    Crystal_
    is a Contributor Alumnusis a Past SPL Winner

    Joined:
    Dec 20, 2009
    Messages:
    874
    This is related to the famous Focus Energy glitch. I think it's interesting at the very least considering how much Critical Hits shape the RBY metagame.

    According to Bulbapedia (http://bulbapedia.bulbagarden.net/wiki/Focus_Energy_(move)), Focus Energy was intended to multiply the crit ratio by 4, but the glitch makes it be quartered instead.

    The way the Critical Hit formula is structured in the games can be summed up to something like this:

    Now, if they only made a mistake on the shift that belongs to when Focus Energy is used, we would have two left shifts and the crit chance would be the same (multiply by 2) regardless of whether Focus Energy had been used or not. This wouldn't make much sense to me, since it would mean that Focus Energy would've been intended to do... nothing.

    I used to think that they may have missed the two shifts (the one for Focus Energy used and the one for Focus Energy not used), but it looks more probable that they just missed the jumps for whatever reason. Anyway, it seems likely to me that the glitch also involved the non focus energy crit ratio, but since a higher crit ratio than intended doesn't look like a glitch, it never went noticed. Another thing to take into account is that the crit ratio was reduced in the next generation and Pokemon went to crit over less than half the times on average (6.25%).

    I made a similar thread in Pokecommunity (http://www.pokecommunity.com/showthread.php?p=7919304) but not many people replied anyway. You can find the detailed code there, but if someone in Smogon is familiar with assembly and can take hsi/her own conclusions, I'd like to hear what he/she thinks about this. In general though, I thought this was interesting enough to share considering the impact of critical hits in competitive play.
    Last edited: Dec 30, 2013
  2. Jorgen

    Jorgen World's Strongest Fairy
    is a Forum Moderator Alumnusis a Community Contributor Alumnusis a Contributor Alumnusis a Past SPL Winner

    Joined:
    Jun 5, 2010
    Messages:
    1,227
    Pokemon RBY: A case study on the horrors wrought by goto and other code jumps.
  3. Joim

    Joim All promises become a lie, all that's bening corrups in time
    is a Site Staff Alumnusis a Battle Server Admin Alumnusis a Programmer Alumnusis a Tiering Contributor Alumnusis a Smogon Media Contributor Alumnusis a Contributor Alumnusis an Administrator Alumnus

    Joined:
    Oct 9, 2012
    Messages:
    1,508
    I'll only put this here

    [​IMG]
    Firestar493, galbia, Doughboy and 9 others like this.
  4. SonicJaxx

    SonicJaxx

    Joined:
    Mar 19, 2014
    Messages:
    6
    I'd say that all makes a lot of sense, good effort. Though I can't see any games of RBY being played 'as they were intended'. I think it will forever be like 'M.Bison and Balrog', people probably like it better the way it turned out.
  5. magic9mushroom

    magic9mushroom

    Joined:
    Dec 7, 2012
    Messages:
    634
    Among other things, Slowbro would jump to the top of OU and be constantly nominated for Uberhood.
  6. KingHeracrossTheBug

    KingHeracrossTheBug

    Joined:
    Jan 2, 2014
    Messages:
    964
    RBY had a lot of glitches, so it is normal

Users Viewing Thread (Users: 0, Guests: 0)