1. The moderators of this forum are Jellicent and Lutra.
  2. Welcome to Smogon Forums! Please take a minute to read the rules.
  3. Click here to ensure that you never miss a new SmogonU video upload!

Gen 2 Gen 2 PS Development - Post bugs here

Discussion in 'Ruins of Alph' started by Joim, Dec 22, 2014.

  1. Texas Cloverleaf

    Texas Cloverleaf meh
    is a Smogon Social Media Contributor Alumnusis a Forum Moderator Alumnusis a Community Contributor Alumnusis a Tiering Contributor Alumnusis a Contributor Alumnusis a Smogon Media Contributor Alumnusis a Battle Server Moderator Alumnus

    Joined:
    Oct 23, 2009
    Messages:
    10,799
    As a matter of fact the fix is implemented and has been positively tested by several users BUT there seems to be discrepancies in when the hidden power reads IVs from the teambuilder relating to at which point you set the generation of your team. This is something that can hopefully be fixed in future updates, but if you set the parameters for your team prior to inputting moves it should work fine. Manually adjusting IVs should similarly work.

    Alternatively I could have no idea what I'm talking about.

    Edit: also possible that the most recent update addressed it entirely
  2. Texas Cloverleaf

    Texas Cloverleaf meh
    is a Smogon Social Media Contributor Alumnusis a Forum Moderator Alumnusis a Community Contributor Alumnusis a Tiering Contributor Alumnusis a Contributor Alumnusis a Smogon Media Contributor Alumnusis a Battle Server Moderator Alumnus

    Joined:
    Oct 23, 2009
    Messages:
    10,799
    Also tagging Zarel to clarify and notify as Shax addressed him but didn't tag so he'd prolly never see the post
  3. Zarel

    Zarel Not a Yuyuko fan
    is a member of the Site Staffis a Battle Server Administratoris a Programmeris a Pokemon Researcheris an Administrator
    Creator of PS

    Joined:
    Aug 16, 2011
    Messages:
    3,572
    It's completely fixed now.
  4. Jorgen

    Jorgen World's Strongest Fairy
    is a Forum Moderator Alumnusis a Community Contributor Alumnusis a Contributor Alumnusis a Past SPL Champion

    Joined:
    Jun 5, 2010
    Messages:
    1,611
    Just to double-check: the display for Double-Edge says 33% recoil. Is it implemented as such for GSC and RBY? Because it should only be 25%.
    Marty likes this.
  5. xJoelituh

    xJoelituh
    is a Pre-Contributor

    Joined:
    Sep 9, 2014
    Messages:
    279
    Marty likes this.
  6. Texas Cloverleaf

    Texas Cloverleaf meh
    is a Smogon Social Media Contributor Alumnusis a Forum Moderator Alumnusis a Community Contributor Alumnusis a Tiering Contributor Alumnusis a Contributor Alumnusis a Smogon Media Contributor Alumnusis a Battle Server Moderator Alumnus

    Joined:
    Oct 23, 2009
    Messages:
    10,799
    xJoelituh likes this.
  7. Marty

    Marty Always more to find
    is a Battle Server Administratoris a Programmeris a Forum Moderatoris a Pokemon Researcher
    Moderator

    Joined:
    Mar 3, 2012
    Messages:
    617
    Oh I forgot to post here that it was fixed/will be fixed soon, thanks xJoelituh!
    I think you're looking at the Gen 1 file? Gen 2 inherits from Gen 3 (which inherits from Gen 5, which inherits from Gen 6), where Double-Edge has 120 power. All I did was move the description and the 25% recoil from Gen 1 to Gen 2, so both would have them. What Gen 1 is doing now is inheriting everything about Double-Edge from Gen 2, but overriding the power with 100.
    xJoelituh likes this.
  8. BKC

    BKC
    is a Team Rater Alumnusis the Smogon Tour Season 16 Championis a defending World Cup of Pokemon championis the Smogon Tour Season 22 Champion

    Joined:
    May 22, 2010
    Messages:
    1,614
    [19:26] <@BKC> what bugs are there still
    [19:27] <&Isa> for some reason its difficult to set misdreavus to female
    [19:27] <&Isa> cloyster succeeded
    [19:27] <&Isa> but misdreavus didnt
    [19:27] <&Isa> which is the most important one
    [19:27] <&Isa> since it runs attract
    [19:27] <&Isa> on some sets

    is there any way this could be looked into / fixed? as far as I'm aware, this is the only real bug left. thanks!
    Marty likes this.
  9. Jorgen

    Jorgen World's Strongest Fairy
    is a Forum Moderator Alumnusis a Community Contributor Alumnusis a Contributor Alumnusis a Past SPL Champion

    Joined:
    Jun 5, 2010
    Messages:
    1,611
    There's also still some moveset bugs. For example, it takes some work for PS to let you use legal Blissey sets (e.g., Heal Bell/Light Screen/Toxic/Softboiled is only accepted when Heal Bell is listed as the last move, otherwise it thinks it's illegal).
  10. Marty

    Marty Always more to find
    is a Battle Server Administratoris a Programmeris a Forum Moderatoris a Pokemon Researcher
    Moderator

    Joined:
    Mar 3, 2012
    Messages:
    617
    Wow, I just took a look at why this might happen and found the Attack DV check for females was completely wrong. Fixed next update!
  11. Roostur

    Roostur Banned deucer.

    Joined:
    Jan 15, 2016
    Messages:
    6
    Quick question. Po has freeze clause in rated matches, Ps doesn't. Which one is correct?
  12. Talenheim

    Talenheim

    Joined:
    Jul 19, 2013
    Messages:
    437
    Due to the freeze mechanics in GSC, I'm pretty sure freeze clause ON is the better idea. While not infinite like gen 1, really feels like it when 'mons are consistently frozen for over 30 turns.
  13. Roostur

    Roostur Banned deucer.

    Joined:
    Jan 15, 2016
    Messages:
    6
    Yeah. Having two mons frozen is not fun. And its happened to me more than once. It's pretty retarded. Though ironically in every game where i've had two frozen mons, i've actually won. It's still kinda bullshit though. We have sleep clause, and u can switch in a sleep talking poke to absorb sleep to get around it. But theres no way around freeze and it seems to always last forever, but there's no clause for that. Not having that rule does seem to be a bit inconsistent.

    What's the arguement for not having freeze clause btw? Doesn't everyone agree we should have it? Pokemon showdown would be clost to perfect then
    Last edited: Jan 29, 2016
  14. Zarel

    Zarel Not a Yuyuko fan
    is a member of the Site Staffis a Battle Server Administratoris a Programmeris a Pokemon Researcheris an Administrator
    Creator of PS

    Joined:
    Aug 16, 2011
    Messages:
    3,572
    I rewrote the gen 2 move validator.

    The new validator is in Smogtours. It fixes many of the issues tested here, but I haven't tested too thoroughly. If you guys want to test it on Smogtours some more before I push it to Main, that'd be greatly appreciated.
    Last edited: Jan 31, 2016
    xJoelituh likes this.
  15. Marty

    Marty Always more to find
    is a Battle Server Administratoris a Programmeris a Forum Moderatoris a Pokemon Researcher
    Moderator

    Joined:
    Mar 3, 2012
    Messages:
    617
    Conveniently, there are only 24 Pokemon in OU so I made 4 teams out of the suggested Smogon sets. The only issue was this Misdreavus:
    Code:
    Misdreavus @ Leftovers
    - Mean Look
    - Perish Song
    - Protect
    - Thunder
    It says it has moves incompatible with its Ability, so I put Ability: Levitate in the export and then it passed. Weird.

    Still, we're down to 1 validator complaint from 6 with these same teams on main, so +1 Zarel!
  16. Jorgen

    Jorgen World's Strongest Fairy
    is a Forum Moderator Alumnusis a Community Contributor Alumnusis a Contributor Alumnusis a Past SPL Champion

    Joined:
    Jun 5, 2010
    Messages:
    1,611
    At least one permutation of Nidoking with EQ/Ice Beam/Lovely Kiss/Counter is rejected, but it's legal as LK can be traded back to RBY.

    I see a similar issue with Lovely Kiss + Swords Dance Victreebel.

    And Clefable with Petal Dance + Body Slam.

    Double-check the validation on event moves that can be traded to RBY and TMs that can only be learned in RBY.
  17. Zarel

    Zarel Not a Yuyuko fan
    is a member of the Site Staffis a Battle Server Administratoris a Programmeris a Pokemon Researcheris an Administrator
    Creator of PS

    Joined:
    Aug 16, 2011
    Messages:
    3,572
    Can you tell me how it gets both Lovely Kiss and Counter? Lovely Kiss is an event move and Counter is an egg move. How do you get both on the same pokemon?
  18. Isa

    Isa CHINGUYA
    is a Tournament Director Alumnusis a Smogon Social Media Contributor Alumnusis a Global Moderator Alumnusis a Community Contributor Alumnus

    Joined:
    Dec 1, 2012
    Messages:
    1,481
    counter is a rby tm too
  19. Zarel

    Zarel Not a Yuyuko fan
    is a member of the Site Staffis a Battle Server Administratoris a Programmeris a Pokemon Researcheris an Administrator
    Creator of PS

    Joined:
    Aug 16, 2011
    Messages:
    3,572
    Fixed.

    Fixed.
    xJoelituh and Marty like this.
  20. Jorgen

    Jorgen World's Strongest Fairy
    is a Forum Moderator Alumnusis a Community Contributor Alumnusis a Contributor Alumnusis a Past SPL Champion

    Joined:
    Jun 5, 2010
    Messages:
    1,611
    Crit mechanics seem slightly off. Reflect, Burn, & stat stages are ignored if the attacking stat stage is less than OR equal to the opponent's defense stat stage. Otherwise, nothing is ignored. Relevant post reporting tests of the mechanic.

    In this game, turn 1, Snorlax crits a Frustration and has the power halved by Reflect, even though its Attack stage and Raikou's Defense stage are both 0 (ergo equal, ergo Reflect should be ignored).
    Marty likes this.
  21. Lavos

    Lavos cultivating
    is a Tiering Contributor Alumnusis a Past WCoP Champion

    Joined:
    Mar 17, 2012
    Messages:
    3,723
    tentacruel with rapid spin isn't going through on the teambuilder

    also not sure if this is gen 2 specific, but i just won a match on ladder and received -12 points, why?
  22. Zarel

    Zarel Not a Yuyuko fan
    is a member of the Site Staffis a Battle Server Administratoris a Programmeris a Pokemon Researcheris an Administrator
    Creator of PS

    Joined:
    Aug 16, 2011
    Messages:
    3,572
    Gonna need the exact set; 'cause Rapid Spin by itself is legal.

    Replay?
  23. Bughouse

    Bughouse Like ships in the night, you're passing me by
    is a member of the Site Staffis a Forum Moderator Alumnusis a CAP Contributor Alumnusis a Tiering Contributor Alumnusis a Contributor Alumnus

    Joined:
    May 28, 2010
    Messages:
    5,549
    I'm ~99% sure that Metal Powder only boosts Ditto's Defense in GSC and ADV. Based on the PS calc, I think it is doing this correctly in ADV right now, but the GSC calc shows it boosting both defenses (like it does from DPP onward). I asked Mr.E for help verifying current PS mechs.

    Games against a Zapdos, testing each case:

    http://replay.pokemonshowdown.com/smogtours-gen2ou-122170
    http://replay.pokemonshowdown.com/smogtours-gen2ou-122174
    http://replay.pokemonshowdown.com/smogtours-gen2ou-122175
    http://replay.pokemonshowdown.com/smogtours-gen2ou-122176

    Very important, I know... lol

    Marty can you confirm my recollection? Does this "need" fixing? need in like the least necessary sense ever

    Apparently Marty already DID do testing on this and it's not what I thought. He says it's 1.5x boost to both defenses in GSC and ADV and 2x boost to just Def DPP onward. I would assume since he says so that it is right.

    But it doesn't do that on PS calc. On PS calc it is raising both defenses only by 1.5x for all gens... except ADV, where it boosts Def +1 but doesn't boost SpD at all

    ORAS (open)

    160+ Atk Life Orb Abomasnow Wood Hammer vs. +1 0 HP / 0 Def Ditto: 242-286 (102.1 - 120.6%)
    160+ Atk Life Orb Abomasnow Wood Hammer vs. 0 HP / 0 Def Metal Powder Ditto: 242-286 (102.1 - 120.6%)

    252 SpA Life Orb Abomasnow Blizzard vs. +1 0 HP / 0 SpD Ditto: 220-261 (92.8 - 110.1%)
    252 SpA Life Orb Abomasnow Blizzard vs. 0 HP / 0 SpD Metal Powder Ditto: 220-261 (92.8 - 110.1%)

    GSC (open)
    Aerodactyl Hidden Power Rock vs. +1 Ditto: 81-96 (27 - 32.1%)
    Aerodactyl Hidden Power Rock vs. Metal Powder Ditto: 81-96 (27 - 32.1%)

    Aerodactyl Fire Blast vs. Metal Powder Ditto: 65-77 (21.7 - 25.7%)
    Aerodactyl Fire Blast vs. +1 Ditto: 65-77 (21.7 - 25.7%)
    same for DPP and BW, boosting both defs by 1 stage

    Marty, plz fix on PS! to meet your own observations.
    Last edited: Feb 3, 2016
  24. Mirabel_

    Mirabel_

    Joined:
    Oct 18, 2015
    Messages:
    57
    will do a buttload of tests tomorrow

    EDIT: Tested for like 30 minutes and didn't find anything weird with the Gen 2 validator on smogtours.
    Last edited: Feb 3, 2016
  25. Marty

    Marty Always more to find
    is a Battle Server Administratoris a Programmeris a Forum Moderatoris a Pokemon Researcher
    Moderator

    Joined:
    Mar 3, 2012
    Messages:
    617
    I definitely never said it boosts both defenses in Gen 3; who said I did?

    Metal Powder on Ditto:
    Gen 2 - Defense and Special Defense 1.5x, even after Transforming
    Gen 3 to 6 - Defense 2x, lost after Transforming

    If the damage calc is wrong, that has nothing to do with how it's implemented on PS. PS is right for all gens (except maybe the Gen 2 after Transforming part; I'll check that later). I'll fix the damage calc for all gens as soon as possible, but again, the PS damage calc implementation is completely separate from the battle engine on the server.

Users Viewing Thread (Users: 0, Guests: 0)