Done Fix some of the Gen3 trainer sprites

[Clementine]

Sup!
I recently noticed that the Mr Fuji trainer sprite was a little bit broken.

As you can see on the screenshot on the left, which was taken on PS while using Dark Mode, the white parts of the sprite are transparent instead. I was able to check this on GIMP and this is indeed the case.

This is what it's supposed to look like (I guess)

I also noticed this on other gen3 sprites, I found out that the Gen3 Anabel sprite, the Gen3 Lucy sprite, and the Gen3 Spenser sprite all have the same problem. I tried looking for other broken sprites, but this is all I could find. If anyone notices another sprite with this issue, don't hesitate to send me a message so I can fix them / complete this thread.
I fixed the ones I noticed, so here they are.

PS: If it's not too much to ask, would it be possible to add some of the forgotten sprites?

ethan-pokeathlon

lyra-pokeathlon

maid-gen4pt

pokemaniac-gen2

rocker-gen2

weird-light

 

[Lionyx]

In addition, here are a few trainer sprites that look weird (it's more obvious with PS/Smogon dark mode) due to some white pixels not having been removed.

Old → Fixed

→

beauty-gen2jp

→

kris-gen2jp

→

flannery-gen3

→

lass-gen3rs

→

parasollady-gen3

→

youngcouple-gen3

cc Zarel

 

[Zarel]

I fixed Mr. Fuji (someone DMed a fix to me) but not the others.

chaos Marty do you want to handle this or should I?

 

[Marty]

Thanks guys, I guess I shouldn't have used PS Trainer sprites as a base for this project: https://github.com/smogon/sprites/tree/master/src/canonical/trainers

I'll fix all these issues there and then port them back to PS along with a number of other things I already fixed in that repo, like adding some of those missing sprites and replacing duplicates (such as both male Cooltrainer from RS being the Japanese version for some reason). I intentionally didn't add the non-cosplay Pokéstar Studios stuff there since they aren't really Trainers, but I seem to have missed the Pokéathlon ones.

Please do point out other shoddy Trainer sprite transparencies if you spot any! If they're from Gen 3 they don't have to be fixed by hand, just find them in the appropriate game disassembly. Gen 1 and 2 source files are unfortunately not transparent to begin with.

 

[Marty]

Okay, I've uploaded all these; 12 fixes and 5 new ones you can start using after the next chat hotpatch!