I've actually had pretty good shiny luck, all things considered. All the way back in Silver, I managed to catch a shiny Sneasel and Swinub, then had a shiny Elekid hatch from the egg the Daycare people randomly give you in Crystal. Don't think I ever found any shinies in Gen III, but stumbled...