Donphan is a solid pokemon. He is not great and not bad.
He fills alot of roles and is pretty versatile, that's its main strength. It is tanky and has sturdy so is gauranteed to get steal rocks off. It can clear hazards, has a nice electric immunity, a nice STAB move, and knock off or priority...