Done Knock Off in Gens 3-4

[OOF_MAXIMA]

What type of bug are you reporting? Mechanics

What is the bug?
Knock off is not working properly anymore.

After knocking off an opponent's leftovers, for example, it will be inactive in Gens 3-4 for the rest of the game. However, currently it will reactivate once the opponent switches in again.

Are you able to replicate it? If so, how?
Yes. Simply click knock off on an opposing pokemon, let them switch out, then let them switch back in again.
https://replay.pokemonshowdown.com/gen4ou-2461477653

 

[Hydrametr0nice]

I think this was me and I believe this PR fixes it https://github.com/smogon/pokemon-showdown/pull/11433
I'll confirm later

 

[verbatim]

I think this was me and I believe this PR fixes it https://github.com/smogon/pokemon-showdown/pull/11433
I'll confirm later

When does this go live? Knock Off being undone on switch out is a major change impacting both the ADV and DPP Revival tournaments atm.

Edit: Confirmation that this is also the case in Gen 3.

 

[Hydrametr0nice]

When does this go live? Knock Off being undone on switch out is a major change impacting both the ADV and DPP Revival tournaments atm.

Edit: Confirmation that this is also the case in Gen 3.

We have to wait for an admin to approve the PR. I haven't checked if it actually fixes the issue yet. I'll probably only be able to test it in about 12 hours.

 

[Karthik]

Fixed here https://github.com/smogon/pokemon-showdown/commit/dc48d8234ed6066b120a71e9dba35a6ae7bd7cae