Proposal Display Gen 3 Pressure Accurately for Spectators and in Replays

[Blizihguh]

First off, absolutely beautiful.

Second: Is there any situation where more PP can be lost than shown here, now that this is a thing? If not, I question whether the parathetical is necessary or even accurate anymore. If nothing else it could be something like, "(Pressure is not visible in Gen 3, so the exact value is hidden.)"

 

[Django]

After hitting Suicune once and Aerodactyl 3 times with Surf.
View attachment 806789

Did you mean hitting Aerodactyl twice with Surf here? Aero 3 times + Suicune once should be max 8 pp lost, min 5, so 16-19

 

[Hydrametr0nice]

Did you mean hitting Aerodactyl twice with Surf here? Aero 3 times + Suicune once should be max 8 pp lost, min 5, so 16-19

Sorry, I wasn't explicit.
Turn one: Suicune and Aerodactyl (2 PP + 1 uncertain PP)
Turn two: two Aerodactyl (1 PP + 2 uncertain PP)

Second: Is there any situation where more PP can be lost than shown here, now that this is a thing? If not, I question whether the parathetical is necessary or even accurate anymore. If nothing else it could be something like, "(Pressure is not visible in Gen 3, so the exact value is hidden.)"

I updated to "Pressure is not visible in Gen 3, so in certain situations, the exact amount of PP used may be unknown." and it only shows when there is at least one uncertain PP value.

But I can remove it entirely.

 

[Hydrametr0nice]

After hitting Suicune with Giga Drain.
View attachment 806787

After hitting Suicune and Aerodactyl with Surf (doubles).
View attachment 806788

After hitting Suicune once and Aerodactyl 3 times with Surf (doubles).
View attachment 806789

I'll change the Pressure hint to "Pressure is not visible in Gen 3, so in certain situations, the exact amount of PP used may be unknown."

Edit:
After spamming Surf against two Aerodactyl, the lower bound should be negative by now, but it is correctly truncated to zero.View attachment 806798

Here is the pull request: https://github.com/smogon/pokemon-showdown-client/pull/2607

Implemented! It should arrive at the server in the meantime.