Wind Rider does not make you immune to flying type attacks; it only makes you immune to "wind" moves. Wind moves include things like Hurricane and Bleakwind Storm, but also includes moves like Icy Wind and Heat Wave. Air Slash is not considered a wind move, so that's why Shiftry was not immune...