I dunno if this has been mentioned before, but it looks like Overconfidence only gives the attack boost if the Overconfidence Pokemon itself kills with an attack. If the opponent dies from other damage sources (poison/burn, sandstorm, etc.), then the Overconfidence Pokemon does not get an attack...