Done Allow room owners to join invite only subrooms

[clerica]

Honestly this might be a bug idk but currently it seems that room owners aren't allowed to join invite only subrooms which seems potentially problematic for hopefully obvious reasons. This is made even funnier when you realize the room owner can set a subroom to invite only, and then proceed to lock themself out if they dc. Maybe this is intentional but I feel like this shouldn't happen?

Note this seems to only happen when someone else made the subroom. If the room owner made the subroom this doesn't happen

screenshots from testing

I join the subroom make it io

I refresh and am locked out and when I tried using the /subrooms command I still couldn't join

 

[Mathy]

I consider this a bug, for a couple reasons:

1. you're supposed to be # in a srgc you make even if you're already # in the parent room ok i misread. socks wasnt the creator
2. /roomauth says that "(groupchat) is a modjoin % subroom of (parent), so (parent) users of rank % and above also have authority in this room." which is mostly false because the parent roomauth still can't join the room without being invited.

As it's currently implemented, modjoin only checks the target roomauth (not the parent room) and global auth, which there's a chance is intended but the /roomauth text implies otherwise.

 

[Mathy]

I fixed this and now that we've restarted it should be live!