Needs Triage Bug Report - Mechanics

[oopsgtg]

What type of bug are you reporting? Mechanics

What is the bug?
White Herb does not activate at the correct time in some Generation 3 and 4 interactions.
Most notably if a player leads two Pokemon with the Intimidate ability against a Pokemon holding the White Herb, the White Herb activates after the first Intimidate, which is not correct as on cartridge the White Herb activates after all ability activations.
Additionally, White Herb should activate after a Pokemon with the Intimidate ability switches in against a Pokemon holding the White Herb (however, there is an unintentional port priority bug in Pokemon Emerald which means that only the Pokemon in Player 1's first slot will activate White Herb, XD Gale of Darkness resolves this).
Tests:

Emerald Port Priority tests

(Perspective of Player 1) Snorlax in slot 1, White Herb activates after switching in only for Snorlax

(Perspective of Player 1) Gengar in slot 1, White Herb activates after switching in only for Gengar

(Perspective of Player 1) Dusclops in Player 2 slot 1, White Herb does not activate after switching for any Pokemon

XD: Gale of Darkness tests

Test that White Herb resets both intimidate attack drops on a double intimidate lead

Test that White Herb activates after switching in and after ability activation

Generation 4
Test that White Herb resets both intimidate attack drops on a double intimidate lead

Generation 5 (Correctly implemented)

https://replay.pokemonshowdown.com/gen5vgc2013-2528663859-dwq3tqhp5av1erlhc1rwe7a9rwjw225pw

Are you able to replicate it? If so, how?
Lead two Pokemon with the Intimidate ability against a Pokemon holding the White Herb in Gen 3/4 Double battles or switch in a Pokemon with the Intimidate ability against a Pokemon holding the White Herb.
https://replay.pokemonshowdown.com/gen3doublesou-2529003284-3ahgajytve5xgglvhx3b7wnr2oqho4apw
https://replay.pokemonshowdown.com/gen4vgc2010-2422113252-46ug7myix1wdjpyx1wjsfwemgbn3cd1pw?p2

 

[Hydrametr0nice]

This by itself is a very easy fix (it is how it works in Gens 5+), but, as I mentioned in the Past Gens Research Thread, I think it's best to identify all the switch mechanics in Gens 3 and 4, and implement them correctly, rather than fixing one thing at a time with sub-optimal solutions.