Done Gen 1 Substitute/self-hit confusion interaction

Hydrametr0nice

Hydrametr0nice

Simulator Developer
is a Pre-Contributor
What type of bug are you reporting? Mechanics

What is the bug?
GitHub Issue


In Gen 1,
The same happens with crash damage.

For the different scenarios, this is the hint message displayed:

Crash damage and target has substitute ✅
"In Gen 1, if a Pokemon with a Substitute hurts itself due to confusion or Jump Kick/Hi Jump Kick recoil and the target has a Substitute, the target's Substitute takes the damage."

Confusion damage and target has substitute ✅
"In Gen 1, if a Pokemon with a Substitute hurts itself due to confusion or Jump Kick/Hi Jump Kick recoil and the target has a Substitute, the target's Substitute takes the damage."

Crash damage and target has no substitute ✅
"In Gen 1, if a Pokemon with a Substitute hurts itself due to confusion or Jump Kick/Hi Jump Kick recoil and the target does not have a Substitute there is no damage dealt."

Confusion damage and target has no substitute ‼
"In Gen 1, if a Pokemon with a Substitute hurts itself due to confusion or Jump Kick/Hi Jump Kick recoil and the target has a Substitute, the target's Substitute takes the damage."

The message in the 4th case should be the same as in the 3rd case. I don't know if the damage calculation is correct.

Are you able to replicate it? If so, how?
  1. Become confused
  2. Use substitute
  3. Fail a move because of confusion

230746243-30bacb83-30d9-47a8-be71-bd0218aff3c0.png
 
Here is a replay: https://replay.pokemonshowdown.com/gen1ou-2153520923

For the developer: I think this is happening because the target and source for self-hit confusion in battle.ts#directDamage are the same; i.e. both Pokemon are marked as having a Substitute. That also means the second case mentioned in the OP is also bugged; a Pokemon hitting itself in confusion with Substitute active and the opponent having Substitute active will not deal damage to the opponent's Substitute: https://replay.pokemonshowdown.com/gen1ou-2153527851

That's all assuming the mechanic is correct; I'd prefer to have cartridge footage showcasing it.
 
DaWoblefet said:
Here is a replay: https://replay.pokemonshowdown.com/gen1ou-2153520923

For the developer: I think this is happening because the target and source for self-hit confusion in battle.ts#directDamage are the same; i.e. both Pokemon are marked as having a Substitute. That also means the second case mentioned in the OP is also bugged; a Pokemon hitting itself in confusion with Substitute active and the opponent having Substitute active will not deal damage to the opponent's Substitute: https://replay.pokemonshowdown.com/gen1ou-2153527851

That's all assuming the mechanic is correct; I'd prefer to have cartridge footage showcasing it.
Click to expand...
I just touched this for the first time and made a PR, but I don't have any cartridge footage
 
You must log in or register to reply here.
Back
Top