Not A Bug Sharpness-boosted moves in teambuilder

[Flappington]

What type of bug are you reporting? Teambuilder

What is the bug?
In the code that defines if a move is useless or not, it sometimes does not get to the code that checks if the mon gets the Sharpness ability.
This gets checked in battle-dex-search.ts:1532, while moves in the big switch case return before the client can get to the sharpness code.
I noticed this for Samurot-Hisui, having Aerial Ace (line 1370), Night Slash (line 1454) and Smart Strike (line 1480) marked as usually useless.

Are you able to replicate it? If so, how?
1. Open pokemonshowdown
2. Go to the teambuilder
3. Create a team
4. Add Samurott-Hisui
5. Go to the moves and scroll to Usually Useless moves

 

[DaWoblefet]

Originally, I had marked this as a bug, but on reflection I don't think it is. Aerial Ace, Night Slash, and Smart Strike are all bad moves on Samurott-Hisui, so they should appear in usually useless. Other moves which would otherwise get affected, like Aqua Cutter or Ceaseless Edge, are explicitly marked in the GOOD_WEAK_MOVES array. So I think this is intended.