just to clarify, does this mean that when a pokemon evolves its EVs are basically reset and it starts fresh?
No, it takes a Vaporeon's base stats, adjusts them for level, and then adjusts them for the EVs and IVs you have.
It's the same thing as if you had a Vapoeron at level 1 and got the same IVs and EVs.