I've been pretty lucky with shinies throughout the years and even recently I've unintentionally Masuda'd at least 2, but there's only 2 encounters that are notable IMO:
My very first shiny was a Spinda in Sapphire, but by the time I actually realised how rare they were I had already reset my game for a new playthrough.
The other notable encounter is the Bibarel I met in the great swamp in Diamond. Yeah, as you can imagine I totally freaked out when I saw it, but in the end I just decided to throw balls at it without anything else and hope for the best. (It did work out, though. Too bad that Diamond had already given me a shiny bidoof in one of the early routes, making the Bibarel less special)