Partially Approved Update Useless Move Logic

[Shaymin Sky]

I was asked for some updates on usually useless move logic by setsustsna so after skimming the builder for an hour

- make scale shot useful if + loaded dice

- make Bullet seed useful if + loaded dice

- make belly drum useful is item id is salac berry or learnset has extreme speed, sucker punch, aqua jet, bullet punch (basic priority is usually used with belly drum)

- make cosmic power useful if + healing moves and draining kiss

- make focus energy useful if + scope lens (makes crit 100% not 50%)

- make shadow claw useless if learnset includes poltergeist / rage fist

- make lash out useless if learnset includes knock off

- make grass knot useless if learnset includes Energy Ball / Giga Drain

- make seed bomb useless if learnset includes petal blizzard (same move in singles but petal blizzard is 10 bp higher)

- Make Brick Break useless if learnset includes Drain Punch / Close Combat

- im thinking of having a payback case that checks for base speed and no Knock Off although this may be too niche but its nice for a few Pokemon like machamp / Ting-Lu and likely others that I just don't remember

- Also thinking of increasing the HP value for when counter is returned as useful,

65 base hp is far too low, practically every Pokemon nowadays has 65 base HP, it's a fairly low bar.

There's a lot more possible updates I can list here but you should get the point by now, the useless moves code logic needs a decently large update after going through the code/possible additions.
I'll be working on this immediately if this is approved :3

 

[Tack]

please don't do the grass knot one, that move having 120 base power makes it fairly relevant on zam in bw ou since it lets u 2hko ttar with lorb where eball can't, i'd imagine there's other cases where that's relevant throughout the multitude of formats played on ps but i couldn't speak to them personally

 

[Shaymin Sky]

please don't do the grass knot one, that move having 120 base power makes it fairly relevant on zam in bw ou since it lets u 2hko ttar with lorb where eball can't, i'd imagine there's other cases where that's relevant throughout the multitude of formats played on ps but i couldn't speak to them personally

good point!

 

[Dusk Mage Necrozma]

- make scale shot useful if + loaded dice

- make Bullet seed useful if + loaded dice

- make belly drum useful is item id is salac berry or learnset has extreme speed, sucker punch, aqua jet, bullet punch (basic priority is usually used with belly drum)

Not everyone selects their item before their moveset. I believe it would be best to simply have such moves always be useful.

 

[Zarel]

I'll reserve detailed feedback for the PR. I think in general people are too stingy with the "Useful" designation, though.

 

[emikatana]

- make seed bomb useless if learnset includes petal blizzard (same move in singles but petal blizzard is 10 bp higher)

Can we also make Seed Bomb useless if learnset includes Leaf Blade? Seed Bomb is never better than Leaf Blade unless there is a specific reason why contact is not desired, which makes it usually useless.