Rejected A way to add custom css

[P9]

In the preferences menu, provide an option to import custom css and save it (the way background images work).
we can either let it save plain CSS text or a link that hosts the custom css?
for those who don't know how to write css, we can provide links to css they can use

 

[PartMan]

I use Stylebot for this at the moment

 

[Zarel]

Stylus also exists. The main reason not to store CSS locally is because we need all our localStorage budget for teams...

 

[P9]

Stylus also exists. The main reason not to store CSS locally is because we need all our localStorage budget for teams...

I mean use the link like we use for side servers, i have already tested this in preact client. It appends a “<link href=‘linkToCss’>” to the document when mainmenu loads

 

[Zarel]

Oh, are you looking for a way to change server config from the client? That might not be a bad idea...

 

[HoeenHero]

Oh, are you looking for a way to change server config from the client? That might not be a bad idea...

I know its CSS but are there any security considerations to make when it comes to people passing CSS files around to load into the client?

 

[P9]

like this

 

[Zarel]

I know its CSS but are there any security considerations to make when it comes to people passing CSS files around to load into the client?

Not if the permissions are restricted to admins of registered servers. The main concern is whether people want a different permission than "admin" for configuring servers.

like this

I think make this a /serverconfig command, and put it somewhere other than Options, and that's probably not a bad idea.

 

[HoeenHero]

Not if the permissions are restricted to admins of registered servers. The main concern is whether people want a different permission than "admin" for configuring servers.

I was under the impression that this suggestion was for allowing users to import and use any CSS for their client specifically. Based on p9's screenshots that seems to be the case at least.

 

[P9]

My bad if i failed to make it clear
But HoeenHero is right i wanted to make it a user-preference thing. Each user can set a custom css for their own client only.

Also, as Zarel said a way to change server config from client is not a bad idea if we want that.

 

[Zarel]

Oh. In which case I was right the first time. Just use Stylus or Stylebot.