No, most Salamence sets do not fail. This is just the upcoming mixed Salamence. Unfortunately, most sets I've see scrap Dragon Dance and just keep the Life Orb and go with Dragon Claw_Brick Break_Hydro Pump_Flamethower/Fireblast jus to hit shit super effect all over the place.
Your set is like the old advance GPMence. Try this mixed Sala
Salamence @ Life Orb
Ability: Intimidate
Nature: Any Neutral
EVs: 30 HP / 16 At / 56 Def / 136 Spd / 216 SpA / 56 SpD
*Dragon Dance
*Dragon Claw / Aerial Ace / Brick Break
*Flamethrower / Earthquake
*Hydro Pump / Draco Meteor / Dragon Pulse
Use one dragon move as the STAB. Aerial Ace has such a watered down base power though.
EVs give you 338 HP, 310 in both attacks, 210 in both defenses and 270 speed to outrun everything after a single dragon dance. I was thinking of trying this myself, but Specsmence is just so much better. But this set will not get walled.