Will look Into. You should not be waiting long fwiw
-
The moderator of this forum is jetou.
-
Welcome to Smogon! Take a moment to read the Introduction to Smogon for a run-down on everything Smogon, and make sure you take some time to read the global rules.
Programming Pokémon Showdown Damage Calculator
- Thread starter Austin
- Start date
fixed
Something might be wrong with Dauntless Shield, doesn't seem to be applying Defense buff in Damage Calc
+3 252 Atk Zacian-Crowned Close Combat vs. +1 252 HP / 180+ Def Zamazenta-Crowned: 464-546 (119.5 - 140.7%) -- guaranteed OHKO
Possible damage amounts: (464, 468, 474, 480, 484, 490, 496, 502, 506, 512, 518, 524, 528, 534, 540, 546)
This is with Dauntless Shield
+3 252 Atk Zacian-Crowned Close Combat vs. +1 252 HP / 180+ Def Zamazenta-Crowned: 308-364 (79.3 - 93.8%) -- guaranteed 2HKO
This is without Dauntless Shield, but +1 Defense
+3 252 Atk Zacian-Crowned Close Combat vs. +1 252 HP / 180+ Def Zamazenta-Crowned: 464-546 (119.5 - 140.7%) -- guaranteed OHKO
Possible damage amounts: (464, 468, 474, 480, 484, 490, 496, 502, 506, 512, 518, 524, 528, 534, 540, 546)
This is with Dauntless Shield
+3 252 Atk Zacian-Crowned Close Combat vs. +1 252 HP / 180+ Def Zamazenta-Crowned: 308-364 (79.3 - 93.8%) -- guaranteed 2HKO
This is without Dauntless Shield, but +1 Defense
I noticed there was a "switching out" button, presumably just for Pursuit. However, there are a few things that change damage when the target is switching in, like Fishious Rend, Bolt Beak, Stakeout, and Gen 4 Payback. I think there should either also be a "switching in" button, or just have a single "switching" button that automatically applies switching out or in based on context.
Do you just mean Silvally with a memory item?
When I test silvally with a memory item it is getting the same damage result as silvally with no item? Which is what it should be doing when looking at the code
https://replay.pokemonshowdown.com/smogtours-gen8nu-503196
Maybe it's impossible to fix in the calculator then? What I am trying to say is that Silvally forms with the memory equipped are always taking itemless damage as it is impossible to knock them, but the calc defaults to normal, item equipped damage. This replay shows it taking 12%, but this is impossible for item equipped damage and the item cannot be removed from Silvally.
They're both my teams being used, so I know for a fact the 12% damage is only accurate if itemless damage is being done:
252 Atk Mold Breaker Sawk Knock Off (97.5 BP) vs. 0 HP / 0 Def Silvally-Dark: 53-63 (16 - 19%) -- possible 6HKO
252 Atk Mold Breaker Sawk Knock Off vs. 0 HP / 0 Def Silvally-Dark: 36-43 (10.8 - 12.9%) -- possible 8HKO
I just deployed an update which should have the current levels, however:
Random Battle formats change implementations very often and the calc will never be a source of truth. If we're lucky we get notified when a change goes in and is hotpatched and we can get updated within a few hours, but at its core this is never going to be exact. You should not blindly trust the levels (or moves etc) in the calc, they were only correct at one point and may have been changed. The description helpfully includes the levels in the output so you can verify that the levels are what they say they are, it is merely a convenience, you should still expect to have to change the levels if the Random Battles implementation changes.
Random Doubles levels are a whole other can of worms and pretty much fundamentally will not work with the calc.
If a Pokemon's type is manually changed from what it usually is, could the calc make a note of it?
0 SpA Choice Specs Sheer Force Mewtwo Flamethrower vs. 0 HP / 0 SpD Assault Vest Dry Skin Mew: 153-180 (44.8 - 52.7%) -- 25.8% chance to 2HKO
0 SpA Choice Specs Sheer Force Psychic Fire Mewtwo Flamethrower vs. 0 HP / 0 SpD Assault Vest Dry Skin Dragon Mew: 114-135 (33.4 - 39.5%) -- guaranteed 3HKO
This is mostly relevant for defensive Protean/Libero calcs, as well as generic strength comparisons where the usual target is a typeless Mew or something, though Soak (and Magic Powder lol) is also a situation where it could be useful.
On the topic of types, could there also be toggles for Forest's Curse and Trick-or-Treat? They're almost exclusively useful for stacking weaknesses to get crazy calcs, but hey.
0 SpA Choice Specs Sheer Force Mewtwo Flamethrower vs. 0 HP / 0 SpD Assault Vest Dry Skin Mew: 153-180 (44.8 - 52.7%) -- 25.8% chance to 2HKO
0 SpA Choice Specs Sheer Force Psychic Fire Mewtwo Flamethrower vs. 0 HP / 0 SpD Assault Vest Dry Skin Dragon Mew: 114-135 (33.4 - 39.5%) -- guaranteed 3HKO
This is mostly relevant for defensive Protean/Libero calcs, as well as generic strength comparisons where the usual target is a typeless Mew or something, though Soak (and Magic Powder lol) is also a situation where it could be useful.
On the topic of types, could there also be toggles for Forest's Curse and Trick-or-Treat? They're almost exclusively useful for stacking weaknesses to get crazy calcs, but hey.
This already exists. Look for the selector in the top right.
I was playing with the calc a bit and I found that multi-hit move KO chances are calculated incorrectly.
^The original intention was seeing the chances that one of dragapult's subs can take 4 shuriken hits from specs greninja. However, 22.7-27.7% doesn't seem to match 87.5% chance given by the calc. I did some math and found that the chance is actually ~63.65% (assuming equal probability of each outcome).
^Ironically, a simplified calculation of 62.5% is closer to the actual answer than 87.5%
^That doesn't make much sense considering the mean damage of 4 shuriken hits is 80.25, with 81 and 82 both being above the mean.
^I made dragapult fire/ghost in the above case.
^I tweaked a lot of inputs to get the damage to be the same but rock blast behaves the same way. It seems that most if not all multi-hit moves, such as dragon darts and twineedle (which only cap at two) have the same issue. However, it appears that the parental bond ability calculates KO chances correctly.
^it's easy to see that the actual chance is 1/(16^4), which is a lot far off from 6.3% chance.
^Multi-hit moves seem to be using parts of the KO formula for gens 3-8 (with 16 unique damage amounts) instead of gens 1-2 (39 unique damage amounts).
^The original intention was seeing the chances that one of dragapult's subs can take 4 shuriken hits from specs greninja. However, 22.7-27.7% doesn't seem to match 87.5% chance given by the calc. I did some math and found that the chance is actually ~63.65% (assuming equal probability of each outcome).
^Ironically, a simplified calculation of 62.5% is closer to the actual answer than 87.5%
^I tweaked a lot of inputs to get the damage to be the same but rock blast behaves the same way. It seems that most if not all multi-hit moves, such as dragon darts and twineedle (which only cap at two) have the same issue. However, it appears that the parental bond ability calculates KO chances correctly.
^it's easy to see that the actual chance is 1/(16^4), which is a lot far off from 6.3% chance.
Attachments
I am very confused as to how you came across this (why were you using a mixed Darmanitan?!) but I found out what's wrong, and it is a calculator problem (hence why I'm replying here and not the mechanics research thread). Gorilla Tactics is boosting special attacks on the calculator when it shouldn't.
92+ SpA Gorilla Tactics Darmanitan-Galar Freeze-Dry vs. 0 HP / 0 SpD Dracovish: 168-196 (101.8 - 118.7%) -- guaranteed OHKO
92+ SpA Darmanitan-Galar Freeze-Dry vs. 0 HP / 0 SpD Dracovish: 108-132 (65.4 - 80%) -- guaranteed 2HKO
Please talk to 'turskain'. The repo you link appears to be using code for about 3 years ago, the supported way to integrate the official damage calculator code into your application is with the @smogon/calc NPM package.
Last edited:
Done. These are all annoying edge cases :)
Eiscue-Noice has always been selectable in Random Battle mode, please use the Forme selector
AFAICT, Minior is not supported in S/S random battles, though you can change Minior's forme to Minior-Meteor in S/M in exactly the same way.
This was in fact a regression introduced by the change Hematite suspected. The EOT "damage" actually mixes damage AND recovery into a single value (which is especially bad because order matters wrt eg. leftovers vs. sandstorm), and naively adding it gives all these fun KO chance bugs you've all detected. I've backed out the change, which means unfortunately EOT residuals will not be accounted for (which was what the change was originally intended to fix) for OHKO chance calculation (though we at least wont say "after hail damage" when we're not accounting for hail damage, and we will still show residual damages for multi-turn KOs). Unfortunately, the existing calc's handling of KO chance is woefully inadequate to the point where its not really worth saving, but in the new calculator I'm writing this is handled much more comprehensively.
Could you possibly check again now that the KO chance change was reverted? Thanks.
Oops, I cleverly accounted for the expected HP DV if you selected a set with Hidden Power, but didn't have it update (properly) if you selected Hidden Power as a move after the fact. Fixed, thanks!
This was a bug related to the interaction of Mold Breaker and a misunderstanding of how memory items work (ie. theyre dependent on the species, not the ability), thanks!
fixed
Terrain Pulse is not changing type when terrain is active.
should also be fixed, thanks :)