was not aware of this, was worth bringing up at least. thanks :)I've had a pull request open for a while that fixes this.
https://github.com/smogon/damage-calc/pull/535
was not aware of this, was worth bringing up at least. thanks :)I've had a pull request open for a while that fixes this.
https://github.com/smogon/damage-calc/pull/535
should be hereI have a question that may be weird. I was looking through the github trying to find where the calculator decides to go for a 4HKO, 3HKO, 2HKO odds, etc.
I'm very new to coding and was curious to see a simple way of doing this type of thing. Can someone point to me where it is in the github?
Showdex dev here, this is actually a bug on our end lol since we copied Showdown's code and modified it to calculate the final stats ourselves. We weren't aware of that mechanic and all the unique caveats. That is way more complicated than I ever could have imagined, wow! I tried testing it out myself and I was surprised that the tooltip actually reports the incorrect speed as well if you Agility before getting paralyzed. I used Agility then got paralyzed, and it reported my speed stat as 452 in the tooltip. But the next turn, my opponent moved first, which means my speed actually wasn't 452, it was probably 112 (cause the paralysis debuff was still being applied).These two parts specifically aren't properly integrated into the calc extension for Gen 1: " RBY features only a single move that raises Speed in Agility, which is found on many Pokémon, particularly the legendary birds. Thanks to the way the game handles boosting stats, Agility completely cures the Speed drop inflicted by paralysis upon use". This does not show in the Calcdex, which was very confusing because I would be going against a paralyzed Zapdos with agility and be told I was faster even when I wasn't. There's also this: "Paralysis, along with burn, is subject to the stat reapplication glitch. This means that, if the opposing Pokémon uses a stat-raising move like Swords Dance, the stat drop of your Pokémon's status is reapplied. For example, if a Starmie with 328 Speed were to be paralyzed, it would first drop to 82 as normal. If an opposing Kabutops were to use Swords Dance, though, it would drop further to a mere 20 Speed". Once again there would be times where I made choices based on what Calcdex said that were misleading. You can read more here: https://www.smogon.com/rb/articles/rby_speed
Fixed.Grassy seed (presumably other seeds) give boosts in the terrain but do not reduce knock off damage
252 Atk Choice Band Weavile Knock Off (97.5 BP) vs. +1 252 HP / 0 Def Grassy Seed Prism Armor Necrozma: 222-262 (55.7 - 65.8%) -- guaranteed 2HKO after Grassy Terrain recovery (note the base power listed)
It does seem to get buffed to 60 BP when I deselect Grassy Terrain: '252+ Atk Choice Band Tera Grass Rillaboom Grassy Glide (60 BP) vs. 0 HP / 0 Def Mew: 210-248 (61.5 - 72.7%) -- guaranteed 2HKO'. You can see that yours has the 'after Grassy Terrain recovery' so the terrain must be active if that's the case.View attachment 616877
we just did a test to confirm that grassy glide is buffed to 60bp by tera without terrain, but for now the calc doesn't automatically update it from 55 to 60 when you de-select terrain
Hey, this is just a minor thing, and maybe I'm dumb in case im putting it wrong, but the calc does not automatically count wind raider boost under tailwind
The damage calculator checks if it is specifically by Terapagos-Stellar instead of whether the Pokemon's Tera type is Stellar type, and then the damage calculator will then automatically update the type of Tera Starstorm. If you change the forme to "Terapagos-Stellar", then the damage associated with Tera Starstorm will automatically update.What type of bug are you reporting? Mechanics
What is the bug?
The damage calculator doesn't change Tera Starstorm to the Stellar type when Terapagos terastalizes. Due to this, it does not deal double damage to opposing terastalized pokemon.
Are you able to replicate it? If so, how?
Yes, set up Stellar Terapagos in the calculator. Toggle the opposing pokemon's tera, and change the type of Tera Starstorm
Fixed.Mold Breaker, Turboblaze etc are incorrectly removing the effects of Tablets of Ruin/Vessel of Ruin from calcs. Example from Randbats:
+2 Lvl 76 84 Atk Turboblaze Tera Dragon Reshiram Outrage vs. Lvl 83 84 HP / 84 Def Wo-Chien: 278-328 (100.3 - 118.4%) -- guaranteed OHKO
Ended up doing only 88% because of Tablets of Ruin. Changing Reshiram's ability in the calc to something irrelevant like Triage returns the correct value.
Sword of Ruin makes you immune to Sword of Ruin and Gardevoir traced it.https://replay.pokemonshowdown.com/gen9randombattle-2096466594-1bk9sje65lmyrcm9en10jcj4jtjozhnpw
Last turn, Ice Shard should do 34% min to Gardevoir according to calculator but it only did 25%. Looks like either the calculator is wrong or there's a bug in PS where Sword of Ruin is not taken into account when Gardevoir is out
View attachment 622049