Lego said:Fixed Poison- and Fighting-type moves, at a cursory glance I couldn't see any other (Multi-hit, set damage, etc) that weren't working properly. If you can give me specific examples I'd be happy to fix!
Some moves essentially have custom max powers. Serebii has them all listed properly. The following are moves that exist in the calc that have the wrong max powers, with the correct max powers listed beside them.
Bone Rush - 130
Bullet Seed - 130
Double Hit - 120
Double Iron Bash - 140
Double Kick - 80
Dragon Darts - 130
Dual Chop - 130
Electro Ball - 130
Final Gambit - 100
Fling - 100
Fury Swipes - 100
Gear Grind - 130
Grass Knot - 130
Gyro Ball - 130
Heat Crash - 130
Heavy Slam - 130
Icicle Spear - 130
Low Kick - 100
Multi-Attack - 95 (Regular power needs to be changed from 90 to 120 as well)
Night Shade - 100
Pin Missile - 130
Power Trip - 130
Revenge - 80
Reversal - 100
Rock Blast - 130
Seismic Toss - 75
Sheer Cold - 130
Stored Power - 130
Tail Slap - 130
Weather Ball - 130
OHKO moves have 130 max power. While Sheer Cold is in the calc, Fissure, Horn Drill, and Guillotine are not. These are useful moves on some variants of respectable Pokemon like Excadrill, Snorlax, and Lapras, so it is probably worth putting them in for the convenience of max move power damage calculation. Also, Multi-Attack should become the type matching Silvally's Memory item as a max move, and Weather Ball should become the type matching the weather as a max move.
Weirdly, while the +1 Defense from Dauntless Shield appears to be there now, it doesn't seem to apply in the damage calculation. Attacks still do the same damage to a Zamazenta that has what reads as +1 Defense with Dauntless Shield as they would when lacking the automatic +1 Defense from having another ability. For example, a Zamazenta with Defeatist rightly shows no +1 Defense boost, but it takes the same damage as when it has the apparently phantom +1 Defense from Dauntless Shield. When manually applying a +1 Defense boost while having Dauntless Shield, the calc then says Zamazenta has +2 like it should, though Zamazenta is actually taking damage like it only has +1 and not +2. This also affects the damage output of Body Press.
Leftovers and Black Sludge give incorrect KO chances. For example:
252 Atk Strong Jaw Boltund Thunder Fang vs. 252 HP / 252+ Def Mandibuzz: 92-110 (42.3 - 50.6%) -- 98.9% chance to 3HKO after Leftovers recovery (84.79% chance to 3HKO after accuracy)
This is definitely wrong, as taking 92 damage minimum and recovering only 13 out of 217 HP from Leftovers easily guarantees that the attack will always 3HKO, not merely have a 98.9% chance to do so. The inaccuracy of KO chances with Leftovers / Black Sludge is seen even more clearly here:
252 Atk Magnet Strong Jaw Boltund Thunder Fang vs. 252 HP / 252+ Def Toxapex: 84-102 (53.5 - 64.9%) -- 23.4% chance to 2HKO after Black Sludge recovery (21.12% chance to 2HKO after accuracy)
252 Atk Magnet Strong Jaw Boltund Thunder Fang vs. 252 HP / 252+ Def Toxapex: 84-102 (53.5 - 64.9%) -- guaranteed 2HKO after Black Sludge recovery
The first is from the Battle Stadium calc, and the second is from the Trainer Tower calc. The TT calc definitely has the correct 2HKO chance given the damage.
Thanks for all the fixes so far. It's really appreciated.